Dask internal inherit config #4364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI failures seem to be unrelated (they are the same on master) |
madsbk
reviewed
Dec 16, 2020
|
Thanks @madsbk. From my reading of the code I don't think this would be an problem. It actually appears that the worker gets some values from the config before this is applied. So it may be that today some of these values are missed. I wonder if upstreaming this to |
madsbk
approved these changes
Dec 17, 2020
|
Thanks @madsbk |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting
priority="old"when updating config withDASK_INTERNAL_INHERIT_CONFIGmeans that default config options can never be overridden.When used in
SSHClusterto package up the local config to send to the scheduler and workers any value which has a default set indistributed.yamlwill be returned to the default.This change resolved my issue, however I'm guessing this option was included for a reason. @madsbk do you know why this was added?
Closes #4363
I also added a test for the serialization as I ended up writing one as part of putting together the MVRE for #4363.